On Tue, Oct 02, 2007 at 05:44:23PM +0200, Matthias Koenig wrote: > Karel Zak <kzak@xxxxxxxxxx> writes: > > > On Mon, Sep 24, 2007 at 06:43:31PM +0200, Matthias Koenig wrote: > >> Karel Zak <kzak@xxxxxxxxxx> writes: > >> > >> > On Tue, Sep 11, 2007 at 02:35:33PM +0200, Matthias Koenig wrote: > >> > > >> >> - xstrncpy(loopinfo64.lo_file_name, file, LO_NAME_SIZE); > >> >> + myrealpath(file, res_file, PATH_MAX); > >> >> + xstrncpy(loopinfo64.lo_file_name, res_file, LO_NAME_SIZE); > >> > > >> > The LO_NAME_SIZE is terribly small (64 bytes). > > > I've talked about it with my co-workers and another idea: > > > > "/path/to/very_very_long_name" --> "...to/very_very_long_name" > > > > it means end of path. > > Yes, that's fine with me :) We needn't this thing. Because: /dev/loop0: [0900]:4424222 (/home/projects/util-linux/util-linux-ng/tests/output/ts-fstab-*) kernel is already very creative and add '*' at end of long path... I did some cleanup and losetup(8) uses canonicalized absolute paths now. Thanks for suggestions and the patch. Karel -- Karel Zak <kzak@xxxxxxxxxx> - To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html