A couple more minor nits, that are now fixed in my tree, but not
uploaded to Debian yet.
1. logger should use snprintf
2. mount.8 should mention hfsplus (and probably several others...)
lamont
>From 654dc5b2e426461770a40f801409223bb566fcd4 Mon Sep 17 00:00:00 2001
From: LaMont Jones <lamont@xxxxxxxxxxxx>
Date: Tue, 17 Jul 2007 22:43:15 -0600
Subject: [PATCH] use snprintf instead of sprintf in logger.c
---
misc-utils/logger.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/misc-utils/logger.c b/misc-utils/logger.c
index 5241a19..ae23e34 100644
--- a/misc-utils/logger.c
+++ b/misc-utils/logger.c
@@ -89,9 +89,8 @@ mysyslog(int fd, int logflags, int pri, char *tag, char *msg) {
time_t now;
if (fd > -1) {
- /* avoid snprintf - it does not exist on ancient systems */
if (logflags & LOG_PID)
- sprintf (pid, "[%d]", getpid());
+ snprintf (pid, sizeof(pid)-1, "[%d]", getpid());
else
pid[0] = 0;
if (tag)
@@ -104,8 +103,7 @@ mysyslog(int fd, int logflags, int pri, char *tag, char *msg) {
(void)time(&now);
tp = ctime(&now)+4;
- /* do snprintf by hand - ugly, but for once... */
- sprintf(buf, "<%d>%.15s %.200s%s: %.400s",
+ snprintf(buf, sizeof(buf)-1, "<%d>%.15s %.200s%s: %.400s",
pri, tp, cp, pid, msg);
if (write(fd, buf, strlen(buf)+1) < 0)
--
1.5.2.3
>From 018bafb8047b9a6cb9972f0d457e8cc7b9c79c1b Mon Sep 17 00:00:00 2001
From: LaMont Jones <lamont@xxxxxxxxxxxx>
Date: Tue, 17 Jul 2007 22:34:04 -0600
Subject: [PATCH] mention hfsplus in mount manpage
---
mount/mount.8 | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/mount/mount.8 b/mount/mount.8
index 3716279..4350d90 100644
--- a/mount/mount.8
+++ b/mount/mount.8
@@ -415,6 +415,7 @@ currently supported include:
.IR ext2 ,
.IR ext3 ,
.IR hfs ,
+.IR hfsplus ,
.IR hpfs ,
.IR iso9660 ,
.IR jfs ,
--
1.5.2.3
