On Mon, Jun 11, 2007 at 03:24:45PM -0500, Cliff Wickman wrote:
> This patch was submitted to util-linux-ng on 5/31/2007. But it has
> gotten no comments.
>
> I'm hoping this means no objections. I wouldn't have expected many,
> as these bitmasks are implemented with well tested pre-existing code.
Committed. I found & fix two cosmetic "problems":
> +struct bitmask *bitmask_alloc(unsigned int n)
> +{
> + struct bitmask *bmp;
> +
> + bmp = malloc(sizeof(*bmp));
> + if (bmp == 0)
^^^^^^^^^^
Please, use NULL or "if (!bmp)".
> + return 0;
> + bmp->size = n;
> + bmp->maskp = calloc(longsperbits(n), sizeof(unsigned long));
> + if (bmp->maskp == 0) {
^^^^^^^^^^^^
> + free(bmp);
> + return 0;
> + }
> + return bmp;
Thanks.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
