On Fri, Apr 13, 2007 at 07:29:37AM -0400, Mike Frysinger wrote:
> ---
> mount/umount.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mount/umount.c b/mount/umount.c
> index cadcb06..31076f5 100644
> --- a/mount/umount.c
> +++ b/mount/umount.c
> @@ -349,7 +349,7 @@ umount_one (const char *spec, const char *node, const char *type,
> remnt.mnt_type = remnt.mnt_fsname = NULL;
> remnt.mnt_dir = xstrdup(node);
> remnt.mnt_opts = xstrdup("ro");
> - if (!nomtab)
> + if (!nomtab && mtab_is_writable())
> update_mtab(node, &remnt);
See ftab.c:
void
update_mtab (const char *dir, struct my_mntent *instead) {
mntFILE *mfp, *mftmp;
const char *fnam = MOUNTED;
struct mntentchn mtabhead; /* dummy */
struct mntentchn *mc, *mc0, *absent = NULL;
if (mtab_does_not_exist() || !mtab_is_writable())
^^^^^^^^^^^^^^^^^^^
return;
It means the patch duplicates the check. Unfortunately, the same
duplication is already in mount.c (I will fix it).
I think better will be keep the mtab_is_writable() in
update_mtab() only.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
Red Hat Czech s.r.o.
Purkynova 99/71, 612 45 Brno, Czech Republic
Reg.id: CZ27690016
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
