Hi Mike,
please, by more talkative in your patches. Sometimes I'd like to see
something more than "subject" only :-)
On Fri, Apr 13, 2007 at 07:13:54AM -0400, Mike Frysinger wrote:
> ---
> mount/mount.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/mount/mount.c b/mount/mount.c
> index 309fa10..b4bb020 100644
> --- a/mount/mount.c
> +++ b/mount/mount.c
> @@ -1543,8 +1543,6 @@ main(int argc, char *argv[]) {
> if ((p = strrchr(progname, '/')) != NULL)
> progname = p+1;
>
> - umask(022);
> -
Sorry, NAK.
I don't understand what do you want to fix by this patch. Please,
try to describe the problem.
We have to overwrite the umask, because default for mount(2) is the
umask of the current process. The mount & umount are suid and I don't
think we want to allow non-root users to control umask for mounted
filesystems (when umask= is not defined in fstab together with
user/users option).
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
Red Hat Czech s.r.o.
Purkynova 99/71, 612 45 Brno, Czech Republic
Reg.id: CZ27690016
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
