On Thu, Feb 15, 2007 at 01:31:20PM +0000, Pádraig Brady wrote: > Karel Zak wrote: > > Hi Christian, > > > > some ideas from your patch are really good, but the rest is not so > > perfect after all. > > Sorry I missed the original mail/patch. > Can you send again? Done. > For reference I did the "highlight today" functionality > in cal a couple of years back which has alignment issues, > and have been trying to get the fix in since then: > http://www.pixelbeat.org/patches/cal-2.12q-highlight.diff This patch is already in my mail box ;-) Well, Christian's patch is more about code refactoring rather than about simple bug fix only. (It might good idea to cleanup the code.) > Incidentally I also fixed the weekday alignment for > multibyte locales in the changes I did a couple of years ago There is also other multibyte fix (by RH): http://people.redhat.com/kzak/util-linux/util-linux-2.12p-cal-wide.patch My plan is write some regression tests for the "cal" before playing with these patches. Karel -- Karel Zak <kzak@xxxxxxxxxx> - To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
