On Fri, Jan 17, 2025 at 10:03:20AM +0100, Ahmad Fatoum wrote: > Hello Sascha, > > On 17.01.25 09:32, Sascha Hauer wrote: > > Hi Ahmad, > > > > On Sun, Jan 12, 2025 at 09:34:29AM +0100, Ahmad Fatoum wrote: > >> +MAKE_FIT := $(srctree)/scripts/make_fit.py > >> + > >> +# Use this to override the compression algorithm of the DTBs > >> +FIT_COMPRESSION ?= none > >> + > >> +quiet_cmd_fit = FIT $@ > >> + cmd_fit = $(MAKE_FIT) -o $@ --arch $(CONFIG_ARCH_MKIMAGE_NAME) --os linux \ > >> + --name 'barebox-$(KERNELRELEASE)' \ > >> + $(if $(findstring 1,$(KBUILD_VERBOSE)),-v) \ > >> + $(if $(FIT_DECOMPOSE_DTBS),--decompose-dtbs) \ > >> + --dtb-compress $(FIT_COMPRESSION) -k $< @$(word 2,$^) > > > > I had to drop this and the following patches from this series. > > > > barebox already has a cmd_fit which you are overwriting with this patch. > > The existing FIT target is used for the beagleplay board to build an > > image to be started from U-Boot. I suspect we can just replace existing > > FIT target with your version. > > I renamed it to cmd_itb in this patch that you picked: > https://lore.kernel.org/all/20250106091935.3435710-1-a.fatoum@xxxxxxxxxxxxxx/ I see. This patch was not on the branch I currently tested. I applied 10-13 on master now and it compiles fine. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |