On 07.01.25 15:37, Jules Maselbas wrote:
> sunxi pinctrl driver, adapted from Linux, is split in two parts:
> - pinctrl-sunxi.c that implements gpio, pinctrl and pinmux functions
> - pinctrl-sun50i-a64.c that declare sun50i pins and their functions.
> This file only require minor adaptations and be easily copied from Linux.
>
> The pin functions are needed for uart, SD/MMC, and likely for other
> controllers too.
>
> Signed-off-by: Jules Maselbas <jmaselbas@xxxxxxxx>]
Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> ---
> v1->v2:
> - removed `!IS_ENABLED(CONFIG_PINCTRL)` (Ahmad)
Sascha suggested that of his own volition ;)
> + func_name = sunxi_pinctrl_parse_function_prop(np);
> + if (!func_name) {
> + dev_err(dev, "%s: missing 'function' property\n", np->full_name);
Nitpick: %pOF
> + return -EINVAL;
> + }
Cheers,
Ahmad
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
