Hello Sascha, On 09.01.25 08:44, Sascha Hauer wrote: > Add an extra config option for the dfu command to avoid building it in > non interactive builds which leads to linker errors. > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > --- > commands/Kconfig | 6 ++++++ > commands/Makefile | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/commands/Kconfig b/commands/Kconfig > index 67116ec9fc..a30299abf6 100644 > --- a/commands/Kconfig > +++ b/commands/Kconfig > @@ -2172,6 +2172,12 @@ config CMD_USBGADGET > depends on USB_GADGET > prompt "usbgadget" > > +config CMD_DFU > + bool > + depends on USB_GADGET_DFU > + default y Let's use the occasion and make it not enabled by default? > + prompt "dfu" Please add a help text pointing out usbgdaget and mentioning that the downside of using dfu (blocks shell). Thanks, Ahmad > + > config CMD_WD > bool > depends on WATCHDOG > diff --git a/commands/Makefile b/commands/Makefile > index a98c39637c..0dfa0a33a4 100644 > --- a/commands/Makefile > +++ b/commands/Makefile > @@ -64,7 +64,7 @@ obj-$(CONFIG_CMD_INSMOD) += insmod.o > obj-$(CONFIG_CMD_SPLASH) += splash.o > obj-$(CONFIG_CMD_FBTEST) += fbtest.o > obj-$(CONFIG_CMD_BEEP) += beep.o > -obj-$(CONFIG_USB_GADGET_DFU) += dfu.o > +obj-$(CONFIG_CMD_DFU) += dfu.o > obj-$(CONFIG_USB_GADGET_SERIAL) += usbserial.o > obj-$(CONFIG_CMD_GPIO) += gpio.o > obj-$(CONFIG_CMD_UNCOMPRESS) += uncompress.o -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
