On 07.01.25 15:37, Jules Maselbas wrote:
> divider_get_val can return a negative error code and should not be used
> as a valid divider.
>
> Signed-off-by: Jules Maselbas <jmaselbas@xxxxxxxx>
Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> ---
> v1->v2:
> - changed value to int and removed ret variable (Ahmad)
>
> drivers/clk/clk-divider.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c
> index ccab70aecc..b0df34e858 100644
> --- a/drivers/clk/clk-divider.c
> +++ b/drivers/clk/clk-divider.c
> @@ -307,7 +307,7 @@ static int clk_divider_set_rate(struct clk_hw *hw, unsigned long rate,
> {
> struct clk *clk = clk_hw_to_clk(hw);
> struct clk_divider *divider = to_clk_divider(hw);
> - unsigned int value;
> + int value;
> u32 val;
>
> if (divider->flags & CLK_DIVIDER_READ_ONLY)
> @@ -322,6 +322,8 @@ static int clk_divider_set_rate(struct clk_hw *hw, unsigned long rate,
>
> value = divider_get_val(rate, parent_rate, divider->table,
> divider->width, divider->flags);
> + if (value < 0)
> + return value;
>
> val = readl(divider->reg);
> val &= ~(clk_div_mask(divider->width) << divider->shift);
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
