Hello Jules,
On 07.11.24 15:57, Jules Maselbas wrote:
> This driver is adapted from different sources: Linux, u-boot and p-boot.
> The latter, p-boot (forked from u-boot), is a bootloader for pinephones.
>
> It currently only support PIO xfer but could be further improved to also
> support DMA xfer. This driver is split in three files so it can be used
> by the PBL and barebox proper.
>
> Signed-off-by: Jules Maselbas <jmaselbas@xxxxxxxx>
With below nitpick addressed:
Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> +static int sunxi_mmc_probe(struct device *dev)
> +{
> + struct device_node *np = dev->of_node;
> + struct resource *iores;
> + struct sunxi_mmc_host *host;
> + unsigned int f_min, f_max;
> + int ret;
> +
> + iores = dev_request_mem_resource(dev, 0);
> + if (IS_ERR(iores))
> + return PTR_ERR(iores);
> + host = xzalloc(sizeof(*host));
> + host->base = IOMEM(iores->start);
> + dma_set_mask(dev, DMA_BIT_MASK(32));
> + host->cfg = device_get_match_data(dev);
> +
> + host->gpio_cd = of_get_named_gpio(np, "cd-gpios", 0);
Please use gpiod_get & gpiod_get_valute, which will handle details like active low for you.
Cheers,
Ahmad
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
