Now that common.h is finally just a list of files to include, we can start removing the inclusion of common.h in other headers and include only what's actually needed. Let's start with the raspberry Pi mailbox header and make it (and its users) only include what's actually needed. Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> --- v1 -> v2: - no change --- arch/arm/boards/raspberry-pi/mbox-helpers.c | 1 + include/mach/bcm283x/mbox.h | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/boards/raspberry-pi/mbox-helpers.c b/arch/arm/boards/raspberry-pi/mbox-helpers.c index 3a76ac2b012f..489eb0c91313 100644 --- a/arch/arm/boards/raspberry-pi/mbox-helpers.c +++ b/arch/arm/boards/raspberry-pi/mbox-helpers.c @@ -2,6 +2,7 @@ // SPDX-FileCopyrightText: 2009 Carlo Caione <carlo@xxxxxxxxxxxxxxx> #include <mach/bcm283x/mbox.h> +#include <linux/printk.h> #include "lowlevel.h" struct msg_get_arm_mem { diff --git a/include/mach/bcm283x/mbox.h b/include/mach/bcm283x/mbox.h index cf5143673ab3..fc51b6597560 100644 --- a/include/mach/bcm283x/mbox.h +++ b/include/mach/bcm283x/mbox.h @@ -9,7 +9,9 @@ #ifndef _BCM2835_MBOX_H #define _BCM2835_MBOX_H -#include <common.h> +#include <linux/align.h> +#include <linux/types.h> +#include <linux/string.h> #include <mach/bcm283x/platform.h> -- 2.39.5