On Thu, 07 Nov 2024 15:02:18 +0100, Stefan Kerkmann wrote:
> The checked in `sha256-core.S_shipped` assembly file has a thumb2
> specific workaround applied[1]. This fix wasn't backported to the perl
> script `sha256-armv4.pl` used to generate the assembly, thus when the
> script is run it would regenerate the buggy code.
>
> Under rare circumstances the modification timestamp of `sha256-armv4.pl`
> differs enough from `sha256-core.S_shipped` that make triggers a
> regeneration - leading to a broken sha256 digest on ARMv7 compiled in
> Thumb2 mode. In my case it was a Yocto build of barebox from an external
> source tree. Either the git checkout/clone process produced different
> timestamps, as these are non-deterministic, or I accidentally touched
> the file in another way. The bug expressed itself not in crashes but
> wrong sha256 sums.
>
> [...]
Applied, thanks!
[1/7] arm: crypto: sha256: fix generation of thumb2 assembly
https://git.pengutronix.de/cgit/barebox/commit/?id=636a00bd9a32 (link may not be stable)
[2/7] arm: configs: multi_v5_v6_defconfig: move rpi1 armv6 targets
https://git.pengutronix.de/cgit/barebox/commit/?id=506dc2607820 (link may not be stable)
[3/7] arm: configs: multi_v5_v6_defconfig: enable arm optimized sha1/sha256 digest
https://git.pengutronix.de/cgit/barebox/commit/?id=ea88325d8c6e (link may not be stable)
[4/7] arm: configs: multi_v7_defconfig: compile for thumb2
https://git.pengutronix.de/cgit/barebox/commit/?id=c48cade5d459 (link may not be stable)
[5/7] arm: configs: multi_v7_defconfig: enable arm optimized sha256 digest
https://git.pengutronix.de/cgit/barebox/commit/?id=e66a5d6f1d9b (link may not be stable)
[6/7] arm: configs: multi_v8_defconfig: enable arm optimized sha1/sha256 digest
https://git.pengutronix.de/cgit/barebox/commit/?id=8475ef42aa87 (link may not be stable)
[7/7] test: arm: rpi: run tests against multi_v5_v6_defconfig
https://git.pengutronix.de/cgit/barebox/commit/?id=8768361f59aa (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
