On 07.11.24 15:57, Jules Maselbas wrote: > In the function clk_composite_round_rate a test for a NULL function pointer > guard the call to the round_rate callback but doesn't check for the correct > callback: it should be round_rate instead of set_rate > > Signed-off-by: Jules Maselbas <jmaselbas@xxxxxxxx> Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> > --- > drivers/clk/clk-composite.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c > index 454bfaeb0c..fdf53ce75e 100644 > --- a/drivers/clk/clk-composite.c > +++ b/drivers/clk/clk-composite.c > @@ -65,7 +65,7 @@ static long clk_composite_round_rate(struct clk_hw *hw, unsigned long rate, > > if (!(hw->clk.flags & CLK_SET_RATE_NO_REPARENT) && > mux_clk && > - mux_clk->ops->set_rate) > + mux_clk->ops->round_rate) > return mux_clk->ops->round_rate(clk_to_clk_hw(mux_clk), rate, prate); > > return *prate; -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |