Hello Marco,
On 07.11.24 09:42, Marco Felsch wrote:
> Hi Ahmad,
>
> On 24-11-06, Ahmad Fatoum wrote:
>> clangd warns that "Value size does not match register size specified by
>> the constraint and modifier".
>>
>> Promote the subtraction result to unsigned long to fix this.
>>
>> The 16 is likely unnecessary, but I am hesitant to remove it without testing.
>
> Is it worth to add a comment like: /* TODO: check if 16 is necessary */ ?
I am waiting for Sascha's opinion, we have similar subtractions in i.MX code too.
Cheers,
Ahmad
>
> Regards,
> Marco
>
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
>> ---
>> arch/arm/mach-rockchip/atf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-rockchip/atf.c b/arch/arm/mach-rockchip/atf.c
>> index 1e1861191c99..4c16ec3bc66a 100644
>> --- a/arch/arm/mach-rockchip/atf.c
>> +++ b/arch/arm/mach-rockchip/atf.c
>> @@ -59,7 +59,7 @@ static unsigned long load_elf64_image_phdr(const void *elf)
>> \
>> /* Setup an initial stack for EL2 */ \
>> asm volatile("msr sp_el2, %0" : : \
>> - "r" (SOC##_BAREBOX_LOAD_ADDRESS - 16) : \
>> + "r" ((ulong)SOC##_BAREBOX_LOAD_ADDRESS - 16) : \
>> "cc"); \
>> \
>> bl31_entry(bl31, optee_load_address, \
>> --
>> 2.39.5
>>
>>
>>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
