Linux clk driver supports matching parents via init->parent_data instead of init->parent_names. Add support for this feature to barebox, too. Linux however supports setting a "name" and "fw_name" for a parent clock. "fw_name" is a local name for the provider registering the clock and "name" is a globally unique parent name. For the time being, only support the globally unique "name" field. Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx> --- drivers/clk/clk.c | 48 ++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index bd368782804c9a2cce1ced7826501363c0c2ab2d..be4060e6d5a0d7ecbed729b4d96570d7980f5857 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -476,11 +476,28 @@ int bclk_register(struct clk *clk) return ret; } +static int clk_cpy_name(const char **dst_p, const char *src, bool must_exist) +{ + const char *dst; + + if (!src) { + if (must_exist) + return -EINVAL; + return 0; + } + + *dst_p = dst = xstrdup(src); + if (!dst) + return -ENOMEM; + + return 0; +} + struct clk *clk_register(struct device *dev, struct clk_hw *hw) { struct clk *clk; const struct clk_init_data *init = hw->init; - char **parent_names = NULL; + const char **parent_names = NULL; int i, ret; if (!hw->init) @@ -496,14 +513,29 @@ struct clk *clk_register(struct device *dev, struct clk_hw *hw) clk->parents = xzalloc(sizeof(struct clk *) * clk->num_parents); - if (init->parent_names) { + if (init->parent_names || init->parent_data) { parent_names = xzalloc(init->num_parents * sizeof(char *)); - for (i = 0; i < init->num_parents; i++) - parent_names[i] = xstrdup(init->parent_names[i]); - - clk->parent_names = (const char *const*)parent_names; - + for (i = 0; i < init->num_parents; i++) { + if (init->parent_names) { + ret = clk_cpy_name(&parent_names[i], + init->parent_names[i], true); + } else if (init->parent_data) { + /* Linux copies fw_name and if successful also name. + * As fw_name is not handled in barebox, just copy the + * name field and fallback to hw->clk.name if it doesn't + * exist. + */ + ret = clk_cpy_name(&parent_names[i], + init->parent_data[i].name, + true); + if (ret) + ret = clk_cpy_name(&parent_names[i], + init->parent_data[i].hw->clk.name, + false); + } + } + clk->parent_names = (const char *const *)parent_names; } else { for (i = 0; i < init->num_parents; i++) clk->parents[i] = clk_hw_to_clk(init->parent_hws[i]); @@ -515,7 +547,7 @@ struct clk *clk_register(struct device *dev, struct clk_hw *hw) if (ret) { if (parent_names) { for (i = 0; i < init->num_parents; i++) - free(parent_names[i]); + free(&parent_names[i]); free(parent_names); } free(clk->parents); -- 2.46.0