Hello Sascha,
On 15.10.24 09:13, Sascha Hauer wrote:
> On Mon, Oct 14, 2024 at 01:50:37PM +0200, Ahmad Fatoum wrote:
>> -void reginfo(void)
>> +static void reginfo(void)
>> {
>> puts ("\nMPC5200 registers\n");
>> printf ("MBAR=%08x\n", CFG_MBAR);
>> @@ -61,3 +62,4 @@ void reginfo(void)
>> printf ("\tSDRAMCS1: %08X\n",
>> in_be32((void*)MPC5XXX_SDRAM_CS1CFG));
>> }
>> +DEFINE_SIMPLE_COMMAND(reginfo);
>
> This is great for development, but not so nice for a broader use in the
> tree.
It's meant for one-off things during development and we should at least
have one instance in tree to verify that it still works.
This would be that instance :-)
>
>> -BAREBOX_CMD_START(reginfo)
>> - .cmd = do_reginfo,
>> - BAREBOX_CMD_DESC("print register information")
>
> We are losing the command description and get a "call func reginfo"
> instead which is not really an improvement.
That's how it currently looks like:
https://www.barebox.org/doc/latest/commands/info/reginfo.html
And it's confusing, because it's only implemented for one specific
PowerPC machine. I like the new help text more in this instance.
Cheers,
Ahmad
>
> Sascha
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
