On Tue, Oct 15, 2024 at 09:10:29AM +0200, Sascha Hauer wrote: > > On Mon, 14 Oct 2024 13:50:28 +0200, Ahmad Fatoum wrote: > > Symbols exclusively defined in common.h are a problem, because other > > headers that require them will need to include a lot of extra baggage, > > which in the worst case can lead to cyclic dependencies and in every > > case leads to longer compile times. > > > > This series prepare for removing common.h in other headers by moving > > everything it contains apart from #includes into more fitting existing > > headers that are already being included. > > > > [...] > > Applied, thanks! > > [01/12] include: common.h: move barebox startup functions into separate header > https://git.pengutronix.de/cgit/barebox/commit/?id=e723ea2ed886 (link may not be stable) > [02/12] include: common.h: move ctrlc() functions into stdio.h > https://git.pengutronix.de/cgit/barebox/commit/?id=0421e3c77def (link may not be stable) > [03/12] include: common.h: move out integer string parsing functions > https://git.pengutronix.de/cgit/barebox/commit/?id=af51386c2627 (link may not be stable) > [04/12] include: common.h: move out endianness macro sanity check > https://git.pengutronix.de/cgit/barebox/commit/?id=2a8222c22c2d (link may not be stable) > [05/12] include: common.h: move out user interface functions into stdio.h > https://git.pengutronix.de/cgit/barebox/commit/?id=b3c618880ed5 (link may not be stable) > [06/12] include: common.h: move out memory option parsing prototypes > https://git.pengutronix.de/cgit/barebox/commit/?id=7fa8ca6a4094 (link may not be stable) > [07/12] include: common.h: move out RW_BUF_SIZE definition > https://git.pengutronix.de/cgit/barebox/commit/?id=1b33d75d4b07 (link may not be stable) > [08/12] commands: add macro to simplify defining one shot commands > (no commit info) > [09/12] commands: reginfo: make command mpc5xxx-specific > (no commit info) > [10/12] include: common.h: move out get_ram_size > (no commit info) > [11/12] include: align: reword STACK_ALIGN_ARRAY macro parameter for clarity > (no commit info) > [12/12] ARM: bcm283x: remove common.h include in mbox.h > (no commit info) Hm, I assumed b4 ty would automatically send a "partly applied" message. I've seen this with others using b4 ty apparently. I don't know what went wrong here. In fact I applied patches 1-7. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
