The FIT spec is not very specific and was growing over the past years.
E.g. according U-Boot (doc/usage/fit/source_file_format.rst) either a
"kernel" or "firmware" property is mandatory whereas the fit-overlay
example (doc/usage/fit/overlay-fdt-boot.rst) doesn't fulfil this and
instead allows nodes which do contain only a "fdt" property.
This inconsistency makes it hard to detect the purpose of an
configuration node. So far we have three different configuration nodes
- bootable nodes (the usual use-case):
| config-0 {
| compatible = "machine-compatible";
| kernel = "kernel-img-name";
| fdt = "fdt-img-name";
| }
- firmware only nodes like (doc/usage/fit/sec_firmware_ppa.rst):
| config-1 {
| description = "PPA Secure firmware";
| firmware = "firmware@1";
| loadables = "trustedOS@1", "fuse_scr";
| };
- overlay only nodes:
| config-2 {
| fdt = "fdt-overlay-img-name";
| }
This commit adds an optional match function which can be passed to the
fit_open_configuration() to sort out config nodes which are not
interessting. E.g. the bootm code is only interested in config nodes
which do provide an "kernel" image. The new match function is only
called if no explicit configuration node name was specified.
Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
---
arch/arm/mach-layerscape/ppa.c | 2 +-
common/bootm.c | 13 ++++++++++++-
common/image-fit.c | 20 +++++++++++++++-----
include/image-fit.h | 4 +++-
4 files changed, 31 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-layerscape/ppa.c b/arch/arm/mach-layerscape/ppa.c
index 21efaae3ab32..96877712e737 100644
--- a/arch/arm/mach-layerscape/ppa.c
+++ b/arch/arm/mach-layerscape/ppa.c
@@ -69,7 +69,7 @@ static int ppa_init(void *ppa, size_t ppa_size, void *sec_firmware_addr)
return PTR_ERR(fit);
}
- conf = fit_open_configuration(fit, NULL);
+ conf = fit_open_configuration(fit, NULL, NULL);
if (IS_ERR(conf)) {
pr_err("Cannot open default config in ppa FIT image: %pe\n", conf);
ret = PTR_ERR(conf);
diff --git a/common/bootm.c b/common/bootm.c
index c851ab0456b8..2f1aabc3388c 100644
--- a/common/bootm.c
+++ b/common/bootm.c
@@ -554,6 +554,16 @@ static int bootm_open_os_uimage(struct image_data *data)
return 0;
}
+static bool bootm_fit_config_valid(struct fit_handle *fit,
+ struct device_node *config)
+{
+ /*
+ * Consider only FIT configurations which do provide a loadable kernel
+ * image.
+ */
+ return !!fit_has_image(fit, config, "kernel");
+}
+
static int bootm_open_fit(struct image_data *data)
{
struct fit_handle *fit;
@@ -579,7 +589,8 @@ static int bootm_open_fit(struct image_data *data)
data->os_fit = fit;
data->fit_config = fit_open_configuration(data->os_fit,
- data->os_part);
+ data->os_part,
+ bootm_fit_config_valid);
if (IS_ERR(data->fit_config)) {
pr_err("Cannot open FIT image configuration '%s'\n",
data->os_part ? data->os_part : "default");
diff --git a/common/image-fit.c b/common/image-fit.c
index 008804e6a6c3..24a733cd6b6e 100644
--- a/common/image-fit.c
+++ b/common/image-fit.c
@@ -717,7 +717,9 @@ static int fit_config_verify_signature(struct fit_handle *handle, struct device_
static int fit_find_compatible_unit(struct fit_handle *handle,
struct device_node *conf_node,
- const char **unit)
+ const char **unit,
+ bool (*config_node_valid)(struct fit_handle *handle,
+ struct device_node *config))
{
struct device_node *child = NULL;
struct device_node *barebox_root;
@@ -734,7 +736,12 @@ static int fit_find_compatible_unit(struct fit_handle *handle,
return -ENOENT;
for_each_child_of_node(conf_node, child) {
- int score = of_device_is_compatible(child, machine);
+ int score;
+
+ if (config_node_valid && !config_node_valid(handle, child))
+ continue;
+
+ score = of_device_is_compatible(child, machine);
if (!score && !of_property_present(child, "compatible") &&
of_property_present(child, "fdt")) {
@@ -802,7 +809,9 @@ static int fit_find_compatible_unit(struct fit_handle *handle,
* Return: If successful a pointer to a valid configuration node,
* otherwise a ERR_PTR()
*/
-void *fit_open_configuration(struct fit_handle *handle, const char *name)
+void *fit_open_configuration(struct fit_handle *handle, const char *name,
+ bool (*match_valid)(struct fit_handle *handle,
+ struct device_node *config))
{
struct device_node *conf_node = handle->configurations;
const char *unit, *desc = "(no description)";
@@ -814,7 +823,8 @@ void *fit_open_configuration(struct fit_handle *handle, const char *name)
if (name) {
unit = name;
} else {
- ret = fit_find_compatible_unit(handle, conf_node, &unit);
+ ret = fit_find_compatible_unit(handle, conf_node, &unit,
+ match_valid);
if (ret) {
pr_info("Couldn't get a valid configuration. Aborting.\n");
return ERR_PTR(ret);
@@ -958,7 +968,7 @@ static int do_bootm_sandbox_fit(struct image_data *data)
if (IS_ERR(handle))
return PTR_ERR(handle);
- ret = fit_open_configuration(handle, data->os_part);
+ ret = fit_open_configuration(handle, data->os_part, NULL);
if (ret)
goto out;
diff --git a/include/image-fit.h b/include/image-fit.h
index 0b8e94bf4635..416f1f2c1896 100644
--- a/include/image-fit.h
+++ b/include/image-fit.h
@@ -26,7 +26,9 @@ struct fit_handle *fit_open(const char *filename, bool verbose,
enum bootm_verify verify, loff_t max_size);
struct fit_handle *fit_open_buf(const void *buf, size_t len, bool verbose,
enum bootm_verify verify);
-void *fit_open_configuration(struct fit_handle *handle, const char *name);
+void *fit_open_configuration(struct fit_handle *handle, const char *name,
+ bool (*match_valid)(struct fit_handle *handle,
+ struct device_node *config));
int fit_has_image(struct fit_handle *handle, void *configuration,
const char *name);
int fit_open_image(struct fit_handle *handle, void *configuration,
--
2.39.2
