On Fri, Jun 21, 2024 at 08:18:06AM +0300, Alexander Shiyan wrote: > This driver supports Fairchild FAN53555 Digitally Programmable TinyBuck Regulator. > > Supported ICs: > fan53526, fan53555, rk8600, rk8602, syr827, syr828, tcs4525, tcs4526. > > The driver is written based on the fan53555.c linux kernel driver. > Widely used in new developments based on Rockchip SOCs RK35xx. > > + ret = of_property_read_u32(np, "fcs,suspend-voltage-selector", &val); > + if (!ret) { > + if (val >> 1) { Although is funcionally the same you likely wanted to write val > 1 here. Replaced this with the easier to read version ;) Sascha > + dev_err(di->dev, "Invalid VSEL ID=%u!\n", val); > + ret = -EINVAL; > + goto err; > + } > + > + di->sleep_vsel_id = val; > + } > + -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |