The older rk3128, rk3036 and rk3066a SoCs only supported a pin-function-specific default bias as well as disabling bias with no way to manually choose whether the bias should be a pull-up or a pull-down. We wrongly treated this as if there is no bias, so let's fix that. Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> --- drivers/pinctrl/pinctrl-rockchip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index 4177071f26ff..8e1e868fa78f 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -236,6 +236,8 @@ static enum pin_config_param parse_bias_config(struct device_node *np) return PIN_CONFIG_BIAS_PULL_DOWN; else if (of_property_read_bool(np, "bias-bus-hold")) return PIN_CONFIG_BIAS_BUS_HOLD; + else if (of_property_read_bool(np, "bias-pull-pin-default")) + return PIN_CONFIG_BIAS_PULL_PIN_DEFAULT; else return PIN_CONFIG_BIAS_DISABLE; } -- 2.39.2
