cdev_by_name() returns a cdev without increasing its reference count. In
order to maintain a proper reference counting use cdev_open_by_name()
instead and make sure it's closed afterwards when no longer needed.
Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
---
arch/arm/boards/karo-tx28/tx28-stk5.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boards/karo-tx28/tx28-stk5.c b/arch/arm/boards/karo-tx28/tx28-stk5.c
index d1fd526c00..01a14a33a3 100644
--- a/arch/arm/boards/karo-tx28/tx28-stk5.c
+++ b/arch/arm/boards/karo-tx28/tx28-stk5.c
@@ -310,20 +310,21 @@ static const uint32_t tx28_starterkit_pad_setup[] = {
*/
static int register_persistent_environment(void)
{
- struct cdev *cdev;
+ struct cdev *cdev, *env;
/*
* The TX28 STK5 has only one usable MCI card socket.
* So, we expect its name as "disk0".
*/
- cdev = cdev_by_name("disk0");
+ cdev = cdev_open_by_name("disk0", O_RDONLY);
if (cdev == NULL) {
pr_err("No MCI card preset\n");
return -ENODEV;
}
+ cdev_close(cdev);
/* MCI card is present, also a usable partition on it? */
- cdev = cdev_by_name("disk0.1");
+ cdev = cdev_open_by_name("disk0.1", O_RDONLY);
if (cdev == NULL) {
pr_err("No second partition available\n");
pr_info("Please create at least a second partition with"
@@ -332,9 +333,11 @@ static int register_persistent_environment(void)
}
/* use the full partition as our persistent environment storage */
- cdev = devfs_add_partition("disk0.1", 0, cdev->size,
+ env = devfs_add_partition("disk0.1", 0, cdev->size,
DEVFS_PARTITION_FIXED, "env0");
- return PTR_ERR_OR_ZERO(cdev);
+ cdev_close(cdev);
+
+ return PTR_ERR_OR_ZERO(env);
}
static void tx28_get_ethaddr(void)
--
2.39.2
