On Thu, 02 May 2024 17:17:55 +0200, Ahmad Fatoum wrote: > The barebox driver currently only ensures that the switch is out of > reset, but doesn't actually trigger a reset pulse. > > The Linux driver, on the other hand, holds reset active for 10ms and > then waits a whopping 100ms after reset deassertion. > > This seems excessive by a thousandfold for at least KSZ9893R[1], whose > datasheet states: > > [...] Applied, thanks! [1/3] net: dsa: ksz9477: always toggle reset gpio if available https://git.pengutronix.de/cgit/barebox/commit/?id=372d21e79e30 (link may not be stable) [2/3] net: dsa: ksz9477: report 0 as value when returning error https://git.pengutronix.de/cgit/barebox/commit/?id=6d42b2827243 (link may not be stable) [3/3] net: dsa: ksz9477: return negative error codes on PHY access failures https://git.pengutronix.de/cgit/barebox/commit/?id=eefd990b4cfd (link may not be stable) Best regards, -- Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>