On Mon, 15 Apr 2024 14:26:04 +0200, Jonas Richardsen wrote:
> Currently `of_copy_property` copies the given property even if a property
> with the same name already exists on the destination node.
> This leads to kernel warnings about duplicate properties:
> ```
> [ 0.014063] Duplicate name in chosen, renamed to "stdout-path#1"
> [ 0.014093] Duplicate name in chosen, renamed to "bootargs#1"
> [ 0.014119] Duplicate name in chosen, renamed to "phandle#1"
> [ 0.014197] Duplicate name in reserved-memory, renamed to "#address-cells#1"
> [ 0.014226] Duplicate name in reserved-memory, renamed to "#size-cells#1"
> [ 0.014252] Duplicate name in reserved-memory, renamed to "ranges#1"
> [ 0.014278] Duplicate name in reserved-memory, renamed to "phandle#1"
> ```
> Therefore, the function was changed to return an error if the property
> already exists in the destination.
> The change does not cause any regressions, because the only usage of
> this function occurs within `arch/arm/boards/raspberry-pi/rpi-common.c`
> where the original behaviour of the function is obviously unintended.
>
> [...]
Applied, thanks!
[1/1] of: do not copy properties if they already exist in the destination
https://git.pengutronix.de/cgit/barebox/commit/?id=364a1831678d (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
