On Wed, Apr 03, 2024 at 06:00:56AM +0200, Thorsten Scherer wrote:
> Hi Oleksij,
>
> I spotted some typos.
>
> On Tue, Apr 02, 2024 at 11:26:53AM +0200, Oleksij Rempel wrote:
> > Add fallback support for currently not supported HW. Instead of
> > completely fail, it is better to use some kind of basic devicetree with
> > reduced functionality.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> > ---
> > arch/arm/boards/skov-imx8mp/board.c | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boards/skov-imx8mp/board.c b/arch/arm/boards/skov-imx8mp/board.c
> > index 3b6eb7b080..41122ea1e4 100644
> > --- a/arch/arm/boards/skov-imx8mp/board.c
> > +++ b/arch/arm/boards/skov-imx8mp/board.c
> > @@ -85,6 +85,10 @@ static const struct board_description imx8mp_variants[] = {
> > },
> > };
> >
> > +static const struct board_description imx8mp_basic_viariant = {
>
> s/imx8mp_basic_viariant/imx8mp_basic_variant/
>
> > + .dts_compatible = "skov,imx8mp-skov-basic",
> > +};
> > +
> > static int skov_imx8mp_fixup(struct device_node *root, void *data)
> > {
> > struct device_node *chosen = of_create_node(root, "/chosen");
> > @@ -171,12 +175,12 @@ static int skov_imx8mp_init_variant(struct skov_imx8mp_priv *priv)
> > priv->variant_id = v;
> >
> > if (v >= ARRAY_SIZE(imx8mp_variants)) {
> > - dev_err(dev, "Invalid variant %u\n", v);
> > - return -EINVAL;
> > + dev_warn(dev, "Unsuported variant %u. Fall back to basic variant\n", v);
>
> s/Unsuported/Unsupported/
>
> > + variant = &imx8mp_basic_viariant;
>
> s/imx8mp_basic_viariant/imx8mp_basic_variant/
Fixed while applying.
Thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
