Hello Stefan, On 11.03.24 14:32, Stefan Kerkmann wrote: > Hello Ahmad, > > On 11.03.24 11:13, Ahmad Fatoum wrote: >> Hello Stefan, >> >> On 11.03.24 10:10, Stefan Kerkmann wrote: >>> From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> >>> >>> The Ka-Ro QSXP is a i.MX8M Plus solder down system on module. This >>> commit adds support for the SOM on the QSBASE4 RDK. >>> >>> [1]: https://www.karo-electronics.de/qsxp >>> >>> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> >>> Signed-off-by: Stefan Kerkmann <s.kerkmann@xxxxxxxxxxxxxx> >>> --- >>> arch/arm/boards/Makefile | 1 + >>> arch/arm/boards/karo-qsxp-ml81/Makefile | 4 + >>> arch/arm/boards/karo-qsxp-ml81/board.c | 35 + >>> .../flash-header-karo-qsxp-ml81.imxcfg | 9 + >>> arch/arm/boards/karo-qsxp-ml81/lowlevel.c | 102 ++ >>> arch/arm/boards/karo-qsxp-ml81/lowlevel.h | 8 + >>> arch/arm/boards/karo-qsxp-ml81/lpddr4-timing.c | 1597 ++++++++++++++++++++ >> >> If QSXP is the SoM name, rename the folder name to drop ml81. >> > > See reply to patch 5/6, the full manufacturer part number is `QSXP-ML81` > therefore I vote to keep the `ml81` part. Ok, can you call it QSXP-ML81 in the commit message? >> JFYI, if you want to dynamic frequency scaling for DDR, you'll need some >> more entries here. >> > > I'm unfamiliar with dynamic frequency scaling, so I'm not sure if we > need/want more for a first support of this SOM? No, you don't need more. This is Just For Your Information. Dynamic Frequency Scaling can be useful to reduce power usage. Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
