i.MX fuse numbers are sometimes referred to as the index of the 32bit word, sometimes as bit offsets and the device in /dev/imx_ocotp counts in bytes. To avoid more confusion add some comments to the function headers of functions reading/writing the fuses that clearly state that they take the 32bit word number as input. Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> --- arch/arm/mach-imx/ele.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/ele.c b/arch/arm/mach-imx/ele.c index 095eaec8f6..ce5ad287d8 100644 --- a/arch/arm/mach-imx/ele.c +++ b/arch/arm/mach-imx/ele.c @@ -207,6 +207,16 @@ int imx93_ele_load_fw(void *bl33) return 0; } +/* + * ele_read_common_fuse - read a fuse + * @fuse_id: The fuse to read (in 32bit word number) + * fuse_word: The value read from the fuse + * @response: on return contains the response from ELE + * + * This reads the shadow value of the fuse @fuse_id. + * + * Return: 0 when the ELE call succeeds, negative error code otherwise + */ int ele_read_common_fuse(u16 fuse_id, u32 *fuse_word, u32 *response) { struct ele_msg msg; @@ -228,6 +238,16 @@ int ele_read_common_fuse(u16 fuse_id, u32 *fuse_word, u32 *response) return ret; } +/* + * ele_read_shadow_fuse - read a fuse + * @fuse_id: The fuse to read (in 32bit word number) + * fuse_word: The value read from the fuse + * @response: on return contains the response from ELE + * + * This reads the shadow value of the fuse @fuse_id. + * + * Return: 0 when the ELE call succeeds, negative error code otherwise + */ int ele_read_shadow_fuse(u16 fuse_id, u32 *fuse_word, u32 *response) { struct ele_msg msg; @@ -251,7 +271,7 @@ int ele_read_shadow_fuse(u16 fuse_id, u32 *fuse_word, u32 *response) /* * ele_write_fuse - write a fuse - * @fuse_id: The fuse to write to + * @fuse_id: The fuse to write to (in 32bit word number) * @fuse_val: The value to write to the fuse * @lock: lock fuse after writing * @response: on return contains the response from ELE -- 2.39.2