Hi Steffen,
On 08.03.24 12:17, Steffen Trumtrar wrote:
> @@ -2322,9 +2322,31 @@ void mci_of_parse_node(struct mci_host *host,
>
> host->broken_cd = of_property_read_bool(np, "broken-cd");
> host->non_removable = of_property_read_bool(np, "non-removable");
> - host->no_sd = of_property_read_bool(np, "no-sd");
> - host->no_sdio = of_property_read_bool(np, "no-sdio");
> host->disable_wp = of_property_read_bool(np, "disable-wp");
> +
> + if (of_property_read_bool(np, "full-pwr-cycle"))
> + host->caps2 |= MMC_CAP2_FULL_PWR_CYCLE;
> + if (of_property_read_bool(np, "full-pwr-cycle-in-suspend"))
> + host->caps2 |= MMC_CAP2_FULL_PWR_CYCLE_IN_SUSPEND;
> + if (of_property_read_bool(np, "mmc-hs200-1_8v"))
> + host->caps2 |= MMC_CAP2_HS200_1_8V_SDR;
> + if (of_property_read_bool(np, "mmc-hs200-1_2v"))
> + host->caps2 |= MMC_CAP2_HS200_1_2V_SDR;
> + if (of_property_read_bool(np, "mmc-hs400-1_8v"))
> + host->caps2 |= MMC_CAP2_HS400_1_8V | MMC_CAP2_HS200_1_8V_SDR;
> + if (of_property_read_bool(np, "mmc-hs400-1_2v"))
> + host->caps2 |= MMC_CAP2_HS400_1_2V | MMC_CAP2_HS200_1_2V_SDR;
> + if (of_property_read_bool(np, "mmc-hs400-enhanced-strobe"))
> + host->caps2 |= MMC_CAP2_HS400_ES;
> + if (of_property_read_bool(np, "no-sdio"))
> + host->caps2 |= MMC_CAP2_NO_SDIO;
> + if (of_property_read_bool(np, "no-sd"))
> + host->caps2 |= MMC_CAP2_NO_SD;
> + if (of_property_read_bool(np, "no-mmc"))
> + host->caps2 |= MMC_CAP2_NO_MMC;
> + if (of_property_read_bool(np, "no-mmc-hs400"))
> + host->caps2 &= ~(MMC_CAP2_HS400_1_8V | MMC_CAP2_HS400_1_2V |
> + MMC_CAP2_HS400_ES);
Can you move all the stuff with hs200 and hs400 into it into
an IS_ENABLED(CONFIG_MCI_TUNING)?
With this done: Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> }
>
> void mci_of_parse(struct mci_host *host)
> diff --git a/include/mci.h b/include/mci.h
> index 9a52e3f360..ed2967c889 100644
> --- a/include/mci.h
> +++ b/include/mci.h
> @@ -468,6 +468,36 @@ struct mci_host {
> const char *devname; /**< the devicename for the card, defaults to disk%d */
> unsigned voltages;
> unsigned host_caps; /**< Host's interface capabilities, refer MMC_VDD_* */
> + unsigned caps2; /* More host capabilities */
> +#define MMC_CAP2_BOOTPART_NOACC (1 << 0) /* Boot partition no access */
> +#define MMC_CAP2_FULL_PWR_CYCLE (1 << 2) /* Can do full power cycle */
> +#define MMC_CAP2_FULL_PWR_CYCLE_IN_SUSPEND (1 << 3) /* Can do full power cycle in suspend */
> +#define MMC_CAP2_HS200_1_8V_SDR (1 << 5) /* can support */
> +#define MMC_CAP2_HS200_1_2V_SDR (1 << 6) /* can support */
> +#define MMC_CAP2_HS200 (MMC_CAP2_HS200_1_8V_SDR | \
> + MMC_CAP2_HS200_1_2V_SDR)
> +#define MMC_CAP2_SD_EXP (1 << 7) /* SD express via PCIe */
> +#define MMC_CAP2_SD_EXP_1_2V (1 << 8) /* SD express 1.2V */
> +#define MMC_CAP2_CD_ACTIVE_HIGH (1 << 10) /* Card-detect signal active high */
> +#define MMC_CAP2_RO_ACTIVE_HIGH (1 << 11) /* Write-protect signal active high */
> +#define MMC_CAP2_NO_PRESCAN_POWERUP (1 << 14) /* Don't power up before scan */
> +#define MMC_CAP2_HS400_1_8V (1 << 15) /* Can support HS400 1.8V */
> +#define MMC_CAP2_HS400_1_2V (1 << 16) /* Can support HS400 1.2V */
> +#define MMC_CAP2_HS400 (MMC_CAP2_HS400_1_8V | \
> + MMC_CAP2_HS400_1_2V)
> +#define MMC_CAP2_HSX00_1_8V (MMC_CAP2_HS200_1_8V_SDR | MMC_CAP2_HS400_1_8V)
> +#define MMC_CAP2_HSX00_1_2V (MMC_CAP2_HS200_1_2V_SDR | MMC_CAP2_HS400_1_2V)
> +#define MMC_CAP2_SDIO_IRQ_NOTHREAD (1 << 17)
> +#define MMC_CAP2_NO_WRITE_PROTECT (1 << 18) /* No physical write protect pin, assume that card is always read-write */
> +#define MMC_CAP2_NO_SDIO (1 << 19) /* Do not send SDIO commands during initialization */
> +#define MMC_CAP2_HS400_ES (1 << 20) /* Host supports enhanced strobe */
> +#define MMC_CAP2_NO_SD (1 << 21) /* Do not send SD commands during initialization */
> +#define MMC_CAP2_NO_MMC (1 << 22) /* Do not send (e)MMC commands during initialization */
> +#define MMC_CAP2_CQE (1 << 23) /* Has eMMC command queue engine */
> +#define MMC_CAP2_CQE_DCMD (1 << 24) /* CQE can issue a direct command */
> +#define MMC_CAP2_AVOID_3_3V (1 << 25) /* Host must negotiate down from 3.3V */
> +#define MMC_CAP2_MERGE_CAPABLE (1 << 26) /* Host can merge a segment over the segment size */
> +#define MMC_CAP2_CRYPTO 0
> unsigned f_min; /**< host interface lower limit */
> unsigned f_max; /**< host interface upper limit */
> unsigned clock; /**< Current clock used to talk to the card */
> @@ -478,8 +508,6 @@ struct mci_host {
> int use_dsr; /**< optional dsr usage flag */
> int broken_cd; /**< card detect is broken */
> bool non_removable; /**< device is non removable */
> - bool no_sd; /**< do not send SD commands during initialization */
> - bool no_sdio; /**< do not send SDIO commands during initialization */
> bool disable_wp; /**< ignore write-protect detection logic */
> struct regulator *supply;
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
