efi_handle_t is a typedef for a void pointer. We use either void * directly or unsigned long at places, where a handle would be the more descriptive type. Fix this. Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> --- drivers/serial/efi-stdio.c | 2 +- include/efi.h | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/serial/efi-stdio.c b/drivers/serial/efi-stdio.c index b3b696d8fb3c..a0994168f0db 100644 --- a/drivers/serial/efi-stdio.c +++ b/drivers/serial/efi-stdio.c @@ -430,7 +430,7 @@ static int efi_console_probe(struct device *dev) if (!priv->inputbuffer) return -ENOMEM; - efiret = BS->open_protocol((void *)efi_sys_table->con_in_handle, + efiret = BS->open_protocol(efi_sys_table->con_in_handle, &inex_guid, (void **)&inex, efi_parent_image, diff --git a/include/efi.h b/include/efi.h index ec4c2a522df4..18583bf62594 100644 --- a/include/efi.h +++ b/include/efi.h @@ -601,11 +601,11 @@ struct efi_system_table { struct efi_table_hdr hdr; unsigned long fw_vendor; /* physical addr of CHAR16 vendor string */ u32 fw_revision; - unsigned long con_in_handle; + efi_handle_t con_in_handle; struct efi_simple_input_interface *con_in; - unsigned long con_out_handle; + efi_handle_t con_out_handle; struct efi_simple_text_output_protocol *con_out; - unsigned long stderr_handle; + efi_handle_t stderr_handle; unsigned long std_err; struct efi_runtime_services *runtime; struct efi_boot_services *boottime; @@ -615,9 +615,9 @@ struct efi_system_table { struct efi_loaded_image { u32 revision; - void *parent_handle; + efi_handle_t parent_handle; struct efi_system_table *system_table; - void *device_handle; + efi_handle_t device_handle; void *file_path; void *reserved; u32 load_options_size; -- 2.39.2