On Wed, Feb 21, 2024 at 05:42:49PM +0100, Ahmad Fatoum wrote: > Hello Sascha, > > On 21.02.24 16:03, Sascha Hauer wrote: > > The tqma6ul has several upstream device trees depending on the exact > > board type. This removes the downstream device tree in favour for the > > upstream device trees. The board type can be determined from an EEPROM > > on the board. This patch also adds support for reading the EEPROM and > > picking the right device tree for the board found. > > Is the existing "mba6ulx" device tree not a subset of all boards? > Would it make sense to fall back to that instead of using a specific > DT that may fail on other variants? I don't know if it's a subset of all boards. There are enough TQMa6ul device trees already, I don't think we should keep even more of them around. > > + writel(0x12, iomux + 0x0094); > > + writel(0x0, iomux + 0x05bc); > > + writel(0x1b8b0, iomux + 0x0320); > > + writel(0x12, iomux + 0x0098); > > + writel(0x0, iomux + 0x05c0); > > + writel(0x1b8b0, iomux + 0x0324); > > Could iomux_v3_setup_pad and pinctrl macros be used here instead? Yes, fixed. > > select ARM_USE_COMPRESSED_DTB > > + select BOARD_TQ > > + select I2C > > Is I2C absolutely needed in barebox proper? No, it's not. I though we have to select I2C to get I2C_IMX_EARLY, but apparently that's not necessary. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
