Hi Ahmad,
On Tue, Feb 20, 2024 at 10:25:37AM +0100, Ahmad Fatoum wrote:
> Hello Sam,
>
>
> On 15.02.24 23:29, Sam Ravnborg wrote:
> >> +static noinline void continue_skov_arm9cpu_xload_mmc(void)
> >> +{
> >> + sam9263_lowlevel_init(0x2031B004, 0x10053001);
> > Can this be made more verbose using the existing defines?
> > The above hex codes are not friendly to read, and using the original
> > defines used in the previous patch would help a lot on the readability.
>
> I will use the defines for v2. I am not in favor or going back to define
> it as a struct though as it make sit needlessly cumbersome to port board
> support from at91bootstrap, where the straight hex values are used.
I like the way you did it - where you combined the use of the descriptive
names and the hex-value from at91bootstrap.
Sam
