char is generally unsigned on ARM, but we shouldn't rely on that. HAB code does though and compare a char against 0xdb, which would never succeed if chars were signed. Switch to an explicitly unsigned type to fix this. Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> --- v1 -> v2: - no change --- drivers/hab/habv4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hab/habv4.c b/drivers/hab/habv4.c index 974158fd0c01..4db1e7cc0f3a 100644 --- a/drivers/hab/habv4.c +++ b/drivers/hab/habv4.c @@ -216,11 +216,11 @@ static enum hab_status imx8m_read_sram_events(enum hab_status status, { struct hab_event_record *events[10]; int num_events = 0; - char *sram; + u8 *sram; int i = 0; int internal_index = 0; uint16_t ev_len; - char *end = 0; + u8 *end = 0; struct hab_event_record *search; if (cpu_is_mx8mq()) -- 2.39.2