On 26.10.23 16:34, Marco Felsch wrote: > On 23-10-26, Ahmad Fatoum wrote: >> On 26.10.23 16:27, Marco Felsch wrote: >>> On 23-10-26, Ahmad Fatoum wrote: >>>> On 26.10.23 14:46, Marco Felsch wrote: >>>>> The status parameter is never used so drop it and stop bother the user >>>>> of the script. >>>>> >>>>> Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> >>>> >>>> Our get_maintainer.pl script doesn't have the same breadth of features >>>> as the kernel's and only --status is implemented, thus the check. >>> >>> Where? I see only 'print << 'EOT' <text> EOT' >> >> Ye, the output is similar to what you'd get with the kernel's --status. >> The script is just here, because checkpatch depends on it and calls >> it with --status. > > You still can run it with --status, I just won't enforce it. At least to > me it's not clear why we need to enforce it and I use the script from > time to time and always forget the param. The idea was not to mislead users that assume that barebox get_maintainers.pl behaves the same as Linux. But now thinking about it, just printing the same always won't hurt. >>>>> -die "USAGE: get_maintainer.pl --status\n" unless grep /--status/, @ARGV; >>>>> - >>>>> print <<'EOT' >>>>> Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> (maintainer:BAREBOX) >>>>> barebox@xxxxxxxxxxxxxxxxxxx (open list:BAREBOX) >>>> >>>> -- >>>> Pengutronix e.K. | | >>>> Steuerwalder Str. 21 | http://www.pengutronix.de/ | >>>> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >>>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >>>> >>>> >>> >> >> -- >> Pengutronix e.K. | | >> Steuerwalder Str. 21 | http://www.pengutronix.de/ | >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >> >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
