On 20.10.23 15:03, Marco Felsch wrote: > On 23-10-20, Ahmad Fatoum wrote: >> On i.MX8M(Q/M/N/P), barebox PBL is loaded 0x1000 bytes into ITCM > > Nit: only the i.MX8MQ-EVK was converted. Don't know if the rest is > broken since they don't use the pblb (PBL only). I can't follow what you mean with "don't use the pblb (PBL only)", but the other three 8MQ boards already have a MAX_PBL_MEMORY_SIZE, so as far as this patch is concerned, there's nothing further to do. > >> at address 0x7e00_1000. ITCM is 128K followed by 128K of DTCM. >> >> Therefore, in total, barebox PBL may not exceed 0x3f000. Now that we >> have a common macro for defining boards, let's add a >> MAX_PBL_MEMORY_SIZE_$(entrypoint) into it, so check that we don't >> exceed this size at runtime. >> >> Boards that trip over this, should consider using get_builtin_firmware_ext >> to offload binaries into barebox proper. >> >> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> > > Reviewed-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > >> --- >> images/Makefile.imx | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/images/Makefile.imx b/images/Makefile.imx >> index 50f0a64b3091..ca09853c4b6e 100644 >> --- a/images/Makefile.imx >> +++ b/images/Makefile.imx >> @@ -26,6 +26,7 @@ $(eval >> ifeq ($($(strip $(1))), y) >> pblb-y += $(strip $(2)) >> CFG_$(strip $(2)).pblb.imximg = $(board)/$(strip $(3)).imxcfg >> + MAX_PBL_MEMORY_SIZE_$(strip $(2)) = 0x3f000 >> FILE_barebox-$(strip $(4)).img = $(strip $(2)).pblb.pimximg >> FILE_barebox-$(strip $(4))-s.img = $(strip $(2)).pblb.psimximg >> image-y += barebox-$(strip $(4)).img >> -- >> 2.39.2 >> >> >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
