The init() hook was never used so we can remove it to cleanup the code a bit. Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> --- Changelog: v2: - unchanged - v1-link: https://lore.barebox.org/barebox/20231010143314.2031253-1-m.felsch@xxxxxxxxxxxxxx/T/#t drivers/hab/hab.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/hab/hab.c b/drivers/hab/hab.c index 29379ff871c8..04f88175c857 100644 --- a/drivers/hab/hab.c +++ b/drivers/hab/hab.c @@ -197,7 +197,6 @@ static int imx8m_hab_device_locked_down_ocotp(void) } struct imx_hab_ops { - int (*init)(void); int (*write_srk_hash)(const u8 *srk, unsigned flags); int (*read_srk_hash)(u8 *srk); int (*permanent_write_enable)(int enable); @@ -231,29 +230,20 @@ static struct imx_hab_ops imx8m_hab_ops_ocotp = { static struct imx_hab_ops *imx_get_hab_ops(void) { - static struct imx_hab_ops *ops, *tmp; - int ret; + static struct imx_hab_ops *ops; if (ops) return ops; if (IS_ENABLED(CONFIG_HABV3) && (cpu_is_mx25() || cpu_is_mx35())) - tmp = &imx_hab_ops_iim; + ops = &imx_hab_ops_iim; else if (IS_ENABLED(CONFIG_HABV4) && cpu_is_mx6()) - tmp = &imx6_hab_ops_ocotp; + ops = &imx6_hab_ops_ocotp; else if (IS_ENABLED(CONFIG_HABV4) && cpu_is_mx8mq()) - tmp = &imx8m_hab_ops_ocotp; + ops = &imx8m_hab_ops_ocotp; else return NULL; - if (tmp->init) { - ret = tmp->init(); - if (ret) - return NULL; - } - - ops = tmp; - return ops; } -- 2.39.2
