On 23-10-13, Sascha Hauer wrote: > On Tue, Oct 10, 2023 at 04:32:59PM +0200, Marco Felsch wrote: > > Add dedicated configuration headers which guard the flexspi_* options > > like it is done for the HABV4 configuration block to be more > > user-friendly. > > > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > > --- > > include/mach/imx/flexspi-imx8mm-cfg.h | 10 ++++++++++ > > include/mach/imx/flexspi-imx8mp-cfg.h | 10 ++++++++++ > > 2 files changed, 20 insertions(+) > > create mode 100644 include/mach/imx/flexspi-imx8mm-cfg.h > > create mode 100644 include/mach/imx/flexspi-imx8mp-cfg.h > > > > diff --git a/include/mach/imx/flexspi-imx8mm-cfg.h b/include/mach/imx/flexspi-imx8mm-cfg.h > > new file mode 100644 > > index 000000000000..f7f0310a57f4 > > --- /dev/null > > +++ b/include/mach/imx/flexspi-imx8mm-cfg.h > > @@ -0,0 +1,10 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > + > > +/* > > + * This snippet can be included from a i.MX flash header configuration > > + * file for generating FlexSPI compatible images. > > + */ > > +#if defined(CONFIG_SPI_NXP_FLEXSPI) > > +flexspi_ivtofs 0x1000 > > +flexspi_fcfbofs 0x0 > > +#endif > > What's this #ifdef good for? > > CONFIG_SPI_NXP_FLEXSPI enables the flexspi driver, but this is not > necessary to boot from it, right? The flexspi_* options are used to decide if the barebox image should be flexspi compatible. It also influence the HAB CSF generation since it adds a 2nd CSF slot depending if enabled. We can drop this guard as you already NACKed to use the CONFIG_SPI_NXP_FLEXSPI for HAB decisions. Regards, Marco > > Sascha > > > diff --git a/include/mach/imx/flexspi-imx8mp-cfg.h b/include/mach/imx/flexspi-imx8mp-cfg.h > > new file mode 100644 > > index 000000000000..bbc061241748 > > --- /dev/null > > +++ b/include/mach/imx/flexspi-imx8mp-cfg.h > > @@ -0,0 +1,10 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > + > > +/* > > + * This snippet can be included from a i.MX flash header configuration > > + * file for generating FlexSPI compatible images. > > + */ > > +#if defined(CONFIG_SPI_NXP_FLEXSPI) > > +flexspi_ivtofs 0x0 > > +flexspi_fcfbofs 0x400 > > +#endif > > -- > > 2.39.2 > > > > > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >
