On Mon, Sep 11, 2023 at 12:12:19PM +0200, Ahmad Fatoum wrote:
> In usual configurations, TF-A already prints its version on startup, so
> printing it in barebox again is unnecessary and less informational than
> the TF-A print and complicates running barebox without TF-A.
> Thus just drop it.
I agree the information is not very useful. Also we currently only check
for CONFIG_FIRMWARE_IMX8MQ_ATF, but not the other i.MX8M variants, so
the current code is wrong anyway.
However, would it be useful to do a arm_smccc_smc() call somewhere to
verify the TF-A is generally working as expected?
Sascha
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> ---
> arch/arm/mach-imx/imx8m.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/arch/arm/mach-imx/imx8m.c b/arch/arm/mach-imx/imx8m.c
> index af44b089e08a..c7c799c64bc4 100644
> --- a/arch/arm/mach-imx/imx8m.c
> +++ b/arch/arm/mach-imx/imx8m.c
> @@ -56,7 +56,6 @@ u64 imx8m_uid(void)
> static int imx8m_init(const char *cputypestr)
> {
> void __iomem *src = IOMEM(MX8M_SRC_BASE_ADDR);
> - struct arm_smccc_res res;
>
> genpd_activate();
>
> @@ -66,16 +65,6 @@ static int imx8m_init(const char *cputypestr)
> imx_set_reset_reason(src + IMX7_SRC_SRSR, imx7_reset_reasons);
> pr_info("%s unique ID: %llx\n", cputypestr, imx8m_uid());
>
> - if (IS_ENABLED(CONFIG_ARM_SMCCC) &&
> - IS_ENABLED(CONFIG_FIRMWARE_IMX8MQ_ATF)) {
> - arm_smccc_smc(IMX_SIP_BUILDINFO,
> - IMX_SIP_BUILDINFO_GET_COMMITHASH,
> - 0, 0, 0, 0, 0, 0, &res);
> -
> - if (res.a0 > 0)
> - pr_info("i.MX ARM Trusted Firmware: %s\n", (char *)&res.a0);
> - }
> -
> if (IS_ENABLED(CONFIG_PBL_OPTEE) && tzc380_is_enabled() &&
> !of_find_node_by_path_from(NULL, "/firmware/optee")) {
> static struct of_optee_fixup_data optee_fixup_data = {
> --
> 2.39.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
