On 23-07-10, Ahmad Fatoum wrote: > On 10.07.23 08:36, Marco Felsch wrote: > > Make use of the register definition instead of having magic numbers. No > > functional change. > > > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > > FYI, the code is taken from Linux (with arguments swapped). Patch opportunities ^^ thanks for pointing that out. Regards, Marco > Change is ok though: > > Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> > > > --- > > drivers/net/phy/micrel.c | 12 ++++++++---- > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > > index ef1f919ae7..02d474c442 100644 > > --- a/drivers/net/phy/micrel.c > > +++ b/drivers/net/phy/micrel.c > > @@ -447,23 +447,27 @@ static int ksz9031_config_rgmii_delay(struct phy_device *phydev) > > return 0; > > } > > > > - phy_write_mmd_indirect(phydev, MII_KSZ9031RN_CONTROL_PAD_SKEW, 2, > > + phy_write_mmd_indirect(phydev, MII_KSZ9031RN_CONTROL_PAD_SKEW, > > + MDIO_MMD_WIS, > > FIELD_PREP(MII_KSZ9031RN_RX_CTL_M, rx) | > > FIELD_PREP(MII_KSZ9031RN_TX_CTL_M, tx)); > > > > - phy_write_mmd_indirect(phydev, MII_KSZ9031RN_RX_DATA_PAD_SKEW, 2, > > + phy_write_mmd_indirect(phydev, MII_KSZ9031RN_RX_DATA_PAD_SKEW, > > + MDIO_MMD_WIS, > > FIELD_PREP(MII_KSZ9031RN_RXD3, rx) | > > FIELD_PREP(MII_KSZ9031RN_RXD2, rx) | > > FIELD_PREP(MII_KSZ9031RN_RXD1, rx) | > > FIELD_PREP(MII_KSZ9031RN_RXD0, rx)); > > > > - phy_write_mmd_indirect(phydev, MII_KSZ9031RN_TX_DATA_PAD_SKEW, 2, > > + phy_write_mmd_indirect(phydev, MII_KSZ9031RN_TX_DATA_PAD_SKEW, > > + MDIO_MMD_WIS, > > FIELD_PREP(MII_KSZ9031RN_TXD3, tx) | > > FIELD_PREP(MII_KSZ9031RN_TXD2, tx) | > > FIELD_PREP(MII_KSZ9031RN_TXD1, tx) | > > FIELD_PREP(MII_KSZ9031RN_TXD0, tx)); > > > > - phy_write_mmd_indirect(phydev, MII_KSZ9031RN_CLK_PAD_SKEW, 2, > > + phy_write_mmd_indirect(phydev, MII_KSZ9031RN_CLK_PAD_SKEW, > > + MDIO_MMD_WIS, > > FIELD_PREP(MII_KSZ9031RN_GTX_CLK, tx_clk) | > > FIELD_PREP(MII_KSZ9031RN_RX_CLK, rx_clk)); > > return 0; > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > >
