On Thu, Jul 06, 2023 at 10:32:30AM +0200, Ahmad Fatoum wrote:
> On 06.07.23 10:11, Oleksij Rempel wrote:
> > We have sama5d3_barebox_entry(), so make use of it.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
>
> I expected to see a /memory node removed, but I see now that I removed
> them already in commit:
> 2e7e1d2512b0 ("ARM: AT91: sama5d3: always read memory size from controller")
>
> Given that I missed selecting HAVE_AT91_DDRAMC, this means that booting
> recent barebox without your first patch would lead to an error message during
> boot up that initmem is used as no driver or DT added memory banks.
> System should continue normally though.
Yes, I have this error message. But it work without noticeable issues.
> For boards that already have a memory region in the DT, adding a memory
> region by the driver that is identical should be silently accepted.
>
> Could you verify this to make sure we don't introduce breakage?
> That would also make patch 1 a candidate for being applied to master.
So far, it seems to work fine.
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
