Hello Oleksij, On 06.07.23 07:03, Oleksij Rempel wrote: > Microchip Technology SAMA5D3 Ethernet Development System (EDS) Board > (DM320114) is an MPU-based platform for evaluating Ethernet Switch and > PHY products. Compatible Ethernet Switch and PHY Evaluation Boards > connect to the SAMA5D3 EDS Board via either an RGMII or RMII connector. > The Microchip Technology SAMA5D3 EDS Board is not intended for > stand-alone use and has no Ethernet capabilities when no daughter board > or an USB Ethernet adapter is connected. > > For more information see: > https://www.microchip.com/en-us/development-tool/DM320114 > > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> Few suggestions below. With these addressed: Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> > +SAMA5D3_ENTRY_FUNCTION(start_microchip_sama5d3_eds, r4) > +{ > + void *fdt; > + > + if (IS_ENABLED(CONFIG_DEBUG_LL)) > + dbgu_init(); > + > + fdt = __dtb_z_at91_microchip_sama5d3_eds_start + get_runtime_offset(); > + > + barebox_arm_entry(SAMA5_DDRCS, SZ_256M, fdt); sama5d3_barebox_entry(r4, fdt); This way you don't hardcode memory size and you can use $bootsource, $bootsource_instance in barebox proper. > diff --git a/arch/arm/dts/at91-microchip-sama5d3-eds.dts b/arch/arm/dts/at91-microchip-sama5d3-eds.dts > new file mode 100644 > index 0000000000..870d7905be > --- /dev/null > +++ b/arch/arm/dts/at91-microchip-sama5d3-eds.dts > @@ -0,0 +1,19 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/dts-v1/; > +#include <arm/at91-sama5d3_eds.dts> > +#include "sama5d3.dtsi" > + > +/ { > + chosen { > + environment { > + compatible = "barebox,environment"; > + device-path = &mmc0, "partname:0"; > + file-path = "barebox.env"; > + }; > + }; > + > + memory@20000000 { > + device_type = "memory"; > + reg = <0x20000000 0x10000000>; > + }; You should be able to drop this and rely on the atmel,sama5d3-ddramc driver. > +}; > diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig > index b803a1185d..b7db8665aa 100644 > --- a/arch/arm/mach-at91/Kconfig > +++ b/arch/arm/mach-at91/Kconfig > @@ -604,6 +604,16 @@ config MACH_MICROCHIP_KSZ9477_EVB > help > Select this if you are using Microchip's EVB-KSZ9477 Evaluation Kit. > > +config MACH_MICROCHIP_SAMA5D3_EDS Can you enable this board in at91_multi_defconfig? Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
