Re: [PATCH] nios2: remove arch remains from drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/30/23 11:57, Ian Abbott wrote:
> On 29/06/2023 21:13, Denis Orlov wrote:
>> The architecture was removed back in the commit efccc13513, however some
>> drivers that were available exclusively for NIOS2 were left over. As it
>> has been impossible to compile those since then, it seems reasonable to
>> just get rid of them.
>>
>> Signed-off-by: Denis Orlov <denorl2009@xxxxxxxxx>
>> ---
>>   drivers/serial/Kconfig              |  10 --
>>   drivers/serial/Makefile             |   2 -
>>   drivers/serial/serial_altera.c      |  94 -----------
>>   drivers/serial/serial_altera_jtag.c |  99 ------------
>>   drivers/spi/Kconfig                 |   4 -
>>   drivers/spi/Makefile                |   1 -
>>   drivers/spi/altera_spi.c            | 236 ----------------------------
>>   7 files changed, 446 deletions(-)
>>   delete mode 100644 drivers/serial/serial_altera.c
>>   delete mode 100644 drivers/serial/serial_altera_jtag.c
>>   delete mode 100644 drivers/spi/altera_spi.c
>
> As a point of interest, none of those drivers should really depend on NIOS2.  They are usable on an ARM SoCFPGA system if the FPGA logic contains the corresponding Altera/Intel IP components.
>
> Whether or not anyone needs them in barebox is another matter, but I have certainly used them in ARM SoCFPGA Linux systems booted from barebox.
>

Hmm, maybe those drivers should rather depend on ARCH_SOCFPGA then? Would be great if someone tested them in barebox running on a SoCFPGA. Otherwise, they are just rotting in the source tree, with no actual usage.

Regards,
Denis





[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux