Hi Jules, On 23-06-01, Jules Maselbas wrote: > On Thu, Jun 01, 2023 at 04:38:42PM +0200, Marco Felsch wrote: > > On 23-06-01, Sascha Hauer wrote: > > > On Thu, Jun 01, 2023 at 04:25:06PM +0200, Marco Felsch wrote: > > > > This reverts commit 3641d381e63321016e3bf09504852a6b2a2f879b. > > > > > > > > Since the of_xlate support the gpio-hog support is broken because the > > > > 'gpio' property used to specify the gpio-hog pin does not contain any > > > > phandle. Due to the fact that of_xlate was never implemented the easiest > > > > way to fix the gpio-hog functionality is to revert the commit. > > > > > > 3641d381e63321016e3bf09504852a6b2a2f879b was introduced for sunxi. As > > > Jules is currently working on sunxi support this is likely needed soon, > > > so what's the second easiest way? > > > > There is no sunxi driver within the kernel which make use of of_xlate. > > of_xlate is used by sunxi pinctrl driver, see: > https://elixir.bootlin.com/linux/latest/source/drivers/pinctrl/sunxi/pinctrl-sunxi.c#L975 Thanks for the link, didn't searched the pinctrl driver dir.. Anyway I still think that we should (re-)sync the barebox gpio code with linux. The sync can start with adding the of_xlate support like it is done in linux? This was also my reason for completely revert your patch since a gpiolib sync would adapt the of_xlate handling anyway. Regards, Marco
