Re: [PATCH 0/2] imx-usb-loader: fixes in displaying version number

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 26, 2023 at 06:59:46PM +0200, Johannes Zink wrote:
> As Ahmad pointed out in [1], compilation failed if the prepare make
> target was not called before compiling the imx-usb-loader, which caused
> the generated file not to exist when building for the sandbox target and
> broke the build.
> 
> Instead of continuing to pursue the approach discussed in [2], a rather
> straight-foreward approach of adding utsrelease.h as a dependency to
> scripts has been chosen, as now the already-existing infrastucture can
> be used instead of duplicating code in the Makefile.
> 
> Also, the version number was only set for the Host Tool, but not in the
> target tool, which the second patch of this series fixes.
> 
> As the original patch was accidentaly sent out as a fixup, and as this
> series chooses a slightly different approach, I decided to open a new
> series.
> 
> Best regards
> Johannes
> 
> [1] https://lore.barebox.org/barebox/20230525181320.2277320-1-ahmad@xxxxxx/
> [2] https://lore.barebox.org/barebox/20230526070847.52738-1-j.zink@xxxxxxxxxxxxxx/
> 
> Johannes Zink (2):
>   imx-usb-loader: fix compilation if prepare make target was not called
>     before
>   imx-usb-loader: also add version information on target tool
> 
>  Makefile             | 2 +-
>  scripts/imx/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux