Re: [PATCH v2 08/34] ARM: move arm_mem_scratch_get() lower for consistency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17.05.23 11:03, Sascha Hauer wrote:
> The different arm_mem_* functions all follow the same pattern of
> taking the base address of the upper region minus the size of the
> current region and with the exception of arm_mem_scratch_get() they
> are all below each other. arm_mem_scratch_get() doesn't fit into
> this row, so move it lower.
> 
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>

Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>

> ---
>  arch/arm/include/asm/barebox-arm.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/include/asm/barebox-arm.h b/arch/arm/include/asm/barebox-arm.h
> index 8d8c102081..f5a74b4746 100644
> --- a/arch/arm/include/asm/barebox-arm.h
> +++ b/arch/arm/include/asm/barebox-arm.h
> @@ -81,11 +81,6 @@ static inline unsigned long arm_mem_scratch(unsigned long endmem)
>  	return arm_mem_optee(endmem) - SZ_32K;
>  }
>  
> -static inline const void *arm_mem_scratch_get(void)
> -{
> -	return (const void *)arm_mem_scratch(arm_mem_endmem_get());
> -}
> -
>  static inline unsigned long arm_mem_stack(unsigned long endmem)
>  {
>  	return arm_mem_scratch(endmem) - STACK_SIZE;
> @@ -125,6 +120,11 @@ static inline unsigned long arm_mem_stack_top(unsigned long endmem)
>  	return arm_mem_stack(endmem) + STACK_SIZE;
>  }
>  
> +static inline const void *arm_mem_scratch_get(void)
> +{
> +	return (const void *)arm_mem_scratch(arm_mem_endmem_get());
> +}
> +
>  static inline unsigned long arm_mem_barebox_image(unsigned long membase,
>  						  unsigned long endmem,
>  						  unsigned long size)

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |





[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux