Several files in arch/arm/cpu/ have 32bit and 64bit versions. The 64bit versions have a _64 suffix, but the 32bit versions have none. This can be confusing sometimes as one doesn't know if a file is 32bit specific or common code. Add a _32 suffix to the 32bit files to avoid this confusion. Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> --- arch/arm/Makefile | 5 ++++- arch/arm/cpu/Makefile | 20 +++++++++---------- arch/arm/cpu/{cache.c => cache_32.c} | 0 arch/arm/cpu/{entry_ll.S => entry_ll_32.S} | 0 .../arm/cpu/{exceptions.S => exceptions_32.S} | 0 .../arm/cpu/{interrupts.c => interrupts_32.c} | 0 arch/arm/cpu/{lowlevel.S => lowlevel_32.S} | 0 arch/arm/cpu/{mmu-early.c => mmu-early_32.c} | 0 arch/arm/cpu/{mmu.c => mmu_32.c} | 0 arch/arm/cpu/{setupc.S => setupc_32.S} | 0 .../arm/cpu/{smccc-call.S => smccc-call_32.S} | 0 11 files changed, 14 insertions(+), 11 deletions(-) rename arch/arm/cpu/{cache.c => cache_32.c} (100%) rename arch/arm/cpu/{entry_ll.S => entry_ll_32.S} (100%) rename arch/arm/cpu/{exceptions.S => exceptions_32.S} (100%) rename arch/arm/cpu/{interrupts.c => interrupts_32.c} (100%) rename arch/arm/cpu/{lowlevel.S => lowlevel_32.S} (100%) rename arch/arm/cpu/{mmu-early.c => mmu-early_32.c} (100%) rename arch/arm/cpu/{mmu.c => mmu_32.c} (100%) rename arch/arm/cpu/{setupc.S => setupc_32.S} (100%) rename arch/arm/cpu/{smccc-call.S => smccc-call_32.S} (100%) diff --git a/arch/arm/Makefile b/arch/arm/Makefile index a506f1e3a3..cb88c7b330 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -78,10 +78,13 @@ endif ifeq ($(CONFIG_CPU_V8), y) KBUILD_CPPFLAGS += $(CFLAGS_ABI) $(arch-y) $(tune-y) KBUILD_AFLAGS += -include asm/unified.h -export S64 = _64 +export S64_32 = 64 +export S64 = 64 else KBUILD_CPPFLAGS += $(CFLAGS_ABI) $(arch-y) $(tune-y) $(CFLAGS_THUMB2) KBUILD_AFLAGS += -include asm/unified.h -msoft-float $(AFLAGS_THUMB2) +export S64_32 = 32 +export S32 = 32 endif # Machine directory name. This list is sorted alphanumerically diff --git a/arch/arm/cpu/Makefile b/arch/arm/cpu/Makefile index 7674c1464c..fef2026da5 100644 --- a/arch/arm/cpu/Makefile +++ b/arch/arm/cpu/Makefile @@ -2,15 +2,15 @@ obj-y += cpu.o -obj-$(CONFIG_ARM_EXCEPTIONS) += exceptions$(S64).o interrupts$(S64).o -obj-$(CONFIG_MMU) += mmu$(S64).o mmu-common.o -obj-pbl-y += lowlevel$(S64).o -obj-pbl-$(CONFIG_MMU) += mmu-early$(S64).o +obj-$(CONFIG_ARM_EXCEPTIONS) += exceptions_$(S64_32).o interrupts_$(S64_32).o +obj-$(CONFIG_MMU) += mmu_$(S64_32).o mmu-common.o +obj-pbl-y += lowlevel_$(S64_32).o +obj-pbl-$(CONFIG_MMU) += mmu-early_$(S64_32).o obj-pbl-$(CONFIG_CPU_32v7) += hyp.o AFLAGS_hyp.o :=-Wa,-march=armv7-a -Wa,-mcpu=all AFLAGS_hyp.pbl.o :=-Wa,-march=armv7-a -Wa,-mcpu=all -obj-y += start.o entry.o entry_ll$(S64).o +obj-y += start.o entry.o entry_ll_$(S64_32).o KASAN_SANITIZE_start.o := n pbl-$(CONFIG_CPU_64) += head_64.o @@ -18,7 +18,7 @@ pbl-$(CONFIG_CPU_64) += head_64.o pbl-$(CONFIG_BOARD_ARM_GENERIC_DT) += board-dt-2nd.o pbl-$(CONFIG_BOARD_ARM_GENERIC_DT_AARCH64) += board-dt-2nd-aarch64.o -obj-pbl-y += setupc$(S64).o cache$(S64).o +obj-pbl-y += setupc_$(S64_32).o cache_$(S64_32).o obj-$(CONFIG_ARM_PSCI_CLIENT) += psci-client.o @@ -35,9 +35,9 @@ endif obj-$(CONFIG_ARM_PSCI) += psci.o obj-$(CONFIG_ARM_PSCI_OF) += psci-of.o -obj-pbl-$(CONFIG_ARM_SMCCC) += smccc-call$(S64).o -AFLAGS_smccc-call$(S64).o :=-Wa,-march=armv$(if $(S64),8,7)-a -AFLAGS_smccc-call$(S64).pbl.o :=-Wa,-march=armv$(if $(S64),8,7)-a +obj-pbl-$(CONFIG_ARM_SMCCC) += smccc-call_$(S64_32).o +AFLAGS_smccc-call_$(S64_32).o :=-Wa,-march=armv$(if $(S64),8,7)-a +AFLAGS_smccc-call_$(S64_32).pbl.o :=-Wa,-march=armv$(if $(S64),8,7)-a obj-$(CONFIG_ARM_SECURE_MONITOR) += sm.o sm_as.o AFLAGS_sm_as.o :=-Wa,-march=armv7-a @@ -52,7 +52,7 @@ obj-pbl-$(CONFIG_CPU_64v8) += cache-armv8.o AFLAGS_cache-armv8.o :=-Wa,-march=armv8-a AFLAGS-cache-armv8.pbl.o :=-Wa,-march=armv8-a -pbl-y += entry.o entry_ll$(S64).o +pbl-y += entry.o entry_ll_$(S64_32).o pbl-y += uncompress.o pbl-$(CONFIG_ARM_ATF) += atf.o diff --git a/arch/arm/cpu/cache.c b/arch/arm/cpu/cache_32.c similarity index 100% rename from arch/arm/cpu/cache.c rename to arch/arm/cpu/cache_32.c diff --git a/arch/arm/cpu/entry_ll.S b/arch/arm/cpu/entry_ll_32.S similarity index 100% rename from arch/arm/cpu/entry_ll.S rename to arch/arm/cpu/entry_ll_32.S diff --git a/arch/arm/cpu/exceptions.S b/arch/arm/cpu/exceptions_32.S similarity index 100% rename from arch/arm/cpu/exceptions.S rename to arch/arm/cpu/exceptions_32.S diff --git a/arch/arm/cpu/interrupts.c b/arch/arm/cpu/interrupts_32.c similarity index 100% rename from arch/arm/cpu/interrupts.c rename to arch/arm/cpu/interrupts_32.c diff --git a/arch/arm/cpu/lowlevel.S b/arch/arm/cpu/lowlevel_32.S similarity index 100% rename from arch/arm/cpu/lowlevel.S rename to arch/arm/cpu/lowlevel_32.S diff --git a/arch/arm/cpu/mmu-early.c b/arch/arm/cpu/mmu-early_32.c similarity index 100% rename from arch/arm/cpu/mmu-early.c rename to arch/arm/cpu/mmu-early_32.c diff --git a/arch/arm/cpu/mmu.c b/arch/arm/cpu/mmu_32.c similarity index 100% rename from arch/arm/cpu/mmu.c rename to arch/arm/cpu/mmu_32.c diff --git a/arch/arm/cpu/setupc.S b/arch/arm/cpu/setupc_32.S similarity index 100% rename from arch/arm/cpu/setupc.S rename to arch/arm/cpu/setupc_32.S diff --git a/arch/arm/cpu/smccc-call.S b/arch/arm/cpu/smccc-call_32.S similarity index 100% rename from arch/arm/cpu/smccc-call.S rename to arch/arm/cpu/smccc-call_32.S -- 2.39.2