Code is fine, but clang's -Wparentheses-equality warns when using double parentheses in conditionals that don't do assignment. This aligns with our code style as well, so change it to silence the warning. No functional change. Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> --- common/hush.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/hush.c b/common/hush.c index 5138a1a45ae9..608c0e4937c1 100644 --- a/common/hush.c +++ b/common/hush.c @@ -1837,7 +1837,7 @@ static char **make_list_in(char **inp, char *name) p3 = insert_var_value(inp[i]); p1 = p3; while (*p1) { - if ((*p1 == ' ')) { + if (*p1 == ' ') { p1++; continue; } -- 2.39.2