On 23-03-24, Sascha Hauer wrote: > On Thu, Mar 23, 2023 at 06:30:16PM +0100, Marco Felsch wrote: > > I encounted the below error message on the i.MX8MP if a fastboot gadget > > was up and running and barebox does a reset() or boots the kernel: > > > > ERROR: dwc3 38100000.usb@xxxxxxxxxxx: request 00000000bfd91568 was not queued to ep1out > > > > Printing an error message during usb_ep_dequeue() is more confusing than > > helpful since the usb_ep_dequeue() could be called during unbind() like > > it is done for fastboot. Lower the dev_err() message to dev_dbg() to > > keep the message for developers. > > I saw this message as well, but I deliberately kept it in. Motivated by > this patch I had a look after it. The correct solution is to not dequeue > requests in fastboot_unbind(). fastboot_disable() will already be called > which calls usb_ep_disable() which will dequeue all outstanding > requests. Linux mainline did mention usb_ep_disbale() as well, I wasn't aware of this function. This seems to be the correct fix, ableit linux maintainer also says that this error is not critical and we shouldn't use dev_err() for non critical messages. > See the patch I just sent. Thanks :) Regards, Marco > > Sascha > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >
