On 23-03-13, Ahmad Fatoum wrote: > On 12.03.23 17:29, Marco Felsch wrote: > > since commit f083fffe52 ("ARM: dts: i.MX8MP: add DDRC compatibles") we > > make use of the esdctl driver. This cause the below error since barebox > > try to add the memory twice. > > > > | imx-esdctl 3d400000.memory-controller@xxxxxxxxxxx: probe failed: Device or resource busy > > | initcall imx_esdctl_driver_init+0x0/0x2c failed: No such device > > Starting with commit 0a78ac84e9fe ("memory: fuse overlapping memory banks"), > this should not be leading to errors. Can you increase debugging in > common/resource.c and see why you run into this error? I did this and saw that memory bank ram0 is added added twice: - first by generic of - 2nd by esdctl Regards, Marco > > > > > > Remove the memory node to fix this. > > > > This behaviour was seen on a i.mx8mp-evk but the > > imx8mp-tqma8mpql-mba8mpxl also has a memory node and includes the > > barebox.dtsi. > > > > Fixes: f083fffe52 ("ARM: dts: i.MX8MP: add DDRC compatibles") > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > > --- > > arch/arm/dts/imx8mp-evk.dts | 2 ++ > > arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts | 2 ++ > > 2 files changed, 4 insertions(+) > > > > diff --git a/arch/arm/dts/imx8mp-evk.dts b/arch/arm/dts/imx8mp-evk.dts > > index 0acc3731d5..c7e1f35d2d 100644 > > --- a/arch/arm/dts/imx8mp-evk.dts > > +++ b/arch/arm/dts/imx8mp-evk.dts > > @@ -30,6 +30,8 @@ > > }; > > }; > > > > +/delete-node/ &{/memory@40000000}; > > + > > ðphy1 { > > reset-assert-us = <15000>; > > reset-deassert-us = <100000>; > > diff --git a/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts > > index 6e81f58e27..bf23e40489 100644 > > --- a/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts > > +++ b/arch/arm/dts/imx8mp-tqma8mpql-mba8mpxl.dts > > @@ -24,6 +24,8 @@ > > }; > > }; > > > > +/delete-node/ &{/memory@40000000}; > > + > > &usdhc2 { > > #address-cells = <1>; > > #size-cells = <1>; > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > >