Re: [PATCH 7/8] ARM: dts: imx7d-peb-eval-02: Fix dtc warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sascha,

On 23-03-02, Sascha Hauer wrote:
> Some nodes have a unit name, but no reg property. Drop the unit name
> to avoid dtc warnings.
> 
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> ---
>  arch/arm/dts/imx7d-peb-eval-02.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/dts/imx7d-peb-eval-02.dtsi b/arch/arm/dts/imx7d-peb-eval-02.dtsi
> index 8bde5b13e7..5c2c302d54 100644
> --- a/arch/arm/dts/imx7d-peb-eval-02.dtsi
> +++ b/arch/arm/dts/imx7d-peb-eval-02.dtsi
> @@ -13,21 +13,21 @@
>  		pinctrl-0 = <&pinctrl_leds_eval>;
>  		status = "disabled";
>  
> -		led@0 {
> +		led0 {

To follow the binding doc the name should be led-0. For the below nodes
as well.

Regards,
  Marco

>  			label = "eval_led_1";
>  			gpios = <&gpio2 8 GPIO_ACTIVE_HIGH>;
>  			linux,default-trigger = "gpio";
>  			default-state = "on";
>  		};
>  
> -		led@1 {
> +		led1 {
>  			label = "eval_led_2";
>  			gpios = <&gpio4 4 GPIO_ACTIVE_HIGH>;
>  			linux,default-trigger = "gpio";
>  			default-state = "on";
>  		};
>  
> -		led@2 {
> +		led2 {
>  			label = "eval_led_3";
>  			gpios = <&gpio2 15 GPIO_ACTIVE_HIGH>;
>  			linux,default-trigger = "gpio";
> @@ -41,18 +41,18 @@
>  		pinctrl-0 = <&pinctrl_btns_eval>;
>  		status = "disabled";
>  
> -		userbtn@0 {
> +		userbtn0 {
>  			label = "eval_button_1";
>  			gpios = <&gpio2 9 GPIO_ACTIVE_HIGH>;
>  			linux,code = <0x100>;	/* BTN_MISC */
>  		};
> -		userbtn@1 {
> +		userbtn1 {
>  			label = "eval_button_2";
>  			gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>;
>  			linux,code = <0x100>;   /* BTN_MISC */
>  		};
>  
> -		userbtn@2 {
> +		userbtn2 {
>  			label = "eval_button_3";
>  			gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>;
>  			linux,code = <0x100>;	/* BTN_MISC */
> -- 
> 2.30.2
> 
> 
> 




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux