[PATCH 0/1] STM32MP: protonic/phycore: warn about potential DT breakage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Steffen, Oleksij,

during some DT cleanup I noticed potential subtle breakage in:

  arch/arm/dts/stm32mp151-prtt1c.dts
  arch/arm/dts/stm32mp151-prtt1l-net.dtsi
  arch/arm/dts/stm32mp151-prtt1l.dtsi
  arch/arm/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi
  arch/arm/dts/stm32mp157c-phycore-stm32mp15-som.dtsi

You are duplicating pinctrl nodes defined in dts/src/arm/stm32mp15-pinctrl.dtsi.
These nodes have subnodes called either pins or pins1,2...
Upstream has already moved around nodes that the device trees override,
which may break your board or silently alter your pinmux.

Please either use upstream DT pinctrl nodes without any change or
define your own fully-defined nodes, so they don't clash (e.g.
named rgmii-phycore-barebox without reliance on upstream).

DT may already be partially broken. I see potential issue with
Phycore RGMII for example which changed upstream.

Cheers,
Ahmad (1):
  ARM: dts: STM32MP: protonic/phycore: add note about potential breakage

 arch/arm/dts/stm32mp151-prtt1c.dts                      | 5 +++++
 arch/arm/dts/stm32mp151-prtt1l-net.dtsi                 | 5 +++++
 arch/arm/dts/stm32mp151-prtt1l.dtsi                     | 6 ++++++
 arch/arm/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi | 5 +++++
 4 files changed, 21 insertions(+)

-- 
2.30.2





[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux